Linter: create rule to remove other validation keywords when enum is present based on type #1899

Karan-Palan · 2025-07-27T23:15:23Z

The rule removes:

String enum with numeric validation keywords
Numeric enum with string validation keywords
Object enum with mixed inapplicable validation keywords

…based on type Signed-off-by: karan-palan <[email protected]>

src/extension/alterschema/linter/enum_validation_keywords_default.h

src/core/jsonschema/transformer.cc

… string Signed-off-by: karan-palan <[email protected]>

…alidation-keywords

Signed-off-by: karan-palan <[email protected]>

…alidation-keywords

Karan-Palan · 2025-08-04T11:00:17Z

@jviotti any comments?

test/alterschema/alterschema_lint_2019_09_test.cc

test/alterschema/alterschema_lint_draft0_test.cc

test/alterschema/alterschema_lint_2020_12_test.cc

test/alterschema/alterschema_lint_draft0_test.cc

test/alterschema/alterschema_lint_draft1_test.cc

test/alterschema/alterschema_lint_draft2_test.cc

test/alterschema/alterschema_lint_draft3_test.cc

test/alterschema/alterschema_lint_draft4_test.cc

test/alterschema/alterschema_lint_draft6_test.cc

test/alterschema/alterschema_lint_draft7_test.cc

Signed-off-by: karan-palan <[email protected]>

…alidation-keywords

Signed-off-by: karan-palan <[email protected]>

src/extension/alterschema/linter/enum_validation_keywords_default.h

jviotti · 2025-08-15T13:10:51Z

test/alterschema/alterschema_lint_draft0_test.cc

+    "minimum": 10,
+    "minLength": 2,
+    "minItems": 1,
+    "minProperties": 1,


Your tests, mainly for older versions, are not considering the fact that many of these keywords do not exist in such older versions. For example, minProperties is only present in Draft 4.

The test works because in Draft 0, minProperties is not considered to be a keyword, therefore it applies to "any" type.

However, to make the tests cleaner, can you double check that you are not using any seemingly valid keyword on a Draft version that doesn't actually define it?

To test the above case, we can also have specific new tests that have a non-sense x-foo-bar keyword or something like that, and ensure it doesn't get removed

Signed-off-by: karan-palan <[email protected]>

src/extension/alterschema/linter/non_applicable_enum_validation_keywords.h

test/alterschema/alterschema_lint_2020_12_test.cc

Signed-off-by: karan-palan <[email protected]>

…alidation-keywords

Signed-off-by: karan-palan <[email protected]>

src/extension/alterschema/CMakeLists.txt

src/extension/alterschema/linter/non_applicable_enum_validation_keywords.h

Signed-off-by: karan-palan <[email protected]>

…alidation-keywords

Signed-off-by: karan-palan <[email protected]>

jviotti · 2025-08-28T13:18:21Z

src/extension/alterschema/linter/non_applicable_enum_validation_keywords.h

+            const sourcemeta::core::SchemaWalker &walker,
+            const sourcemeta::core::SchemaResolver &) const
+      -> sourcemeta::core::SchemaTransformRule::Result override {
+    if (!contains_any(vocabularies,


Can you use the new ONLY_CONTINUE_IF for every return false?

That's nice!

jviotti · 2025-08-28T13:18:38Z

src/extension/alterschema/linter/non_applicable_enum_validation_keywords.h

+      return false;
+    }
+
+    return APPLIES_TO_POINTERS(std::move(positions));


Signed-off-by: karan-palan <[email protected]>

create rule to remove other validation keywords when enum is present …

b1db205

…based on type Signed-off-by: karan-palan <[email protected]>

Karan-Palan marked this pull request as ready for review July 28, 2025 09:41

jviotti reviewed Jul 28, 2025

View reviewed changes

src/extension/alterschema/linter/enum_validation_keywords_default.h Outdated Show resolved Hide resolved

jviotti reviewed Jul 28, 2025

View reviewed changes

src/extension/alterschema/linter/enum_validation_keywords_default.h Outdated Show resolved Hide resolved

jviotti reviewed Jul 28, 2025

View reviewed changes

src/core/jsonschema/transformer.cc Outdated Show resolved Hide resolved

Karan-Palan added 4 commits July 28, 2025 19:07

use type to remove keyword chekcs, use walker types instead of manual…

acd7254

… string Signed-off-by: karan-palan <[email protected]>

Merge branch 'main' of github.com:Karan-Palan/core into linter/enum-v…

16d4a1d

…alidation-keywords

attempt to fix macos ci

4e0891e

Signed-off-by: karan-palan <[email protected]>

Merge branch 'main' of github.com:Karan-Palan/core into linter/enum-v…

a016a15

…alidation-keywords